This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 19302 - Comments extension causes an infinite loop
Summary: Comments extension causes an infinite loop
Status: RESOLVED FIXED
Alias: None
Product: webplatform.org
Classification: Unclassified
Component: infrastructure (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: ---
Assignee: Markus Glaser
QA Contact: public-webplatform-bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 21:05 UTC by Ryan Lane
Modified: 2012-10-29 08:59 UTC (History)
4 users (show)

See Also:

Attachments

Description Ryan Lane 2012-10-05 21:05:19 UTC 
This is likely only for users who aren't email confirmed.
Comment 2 Markus Glaser 2012-10-06 00:26:48 UTC 
I found a hook look in OutputPageBeforeHTML: Comments extension binds to OutputPageBeforeHTML. This in turn calls SemanticForms, which adds text to the wgOut object, which in turn calls OutputPageBeforeHTML.

In order to fix it, I put a flag in the main rendering function in Comments that indicates that rendering is already in progress and prevents another execution of the hooked function.

For testing, I created a new account and did not confirm any email. Then I went to the problematic article and added a comment. This worked for me.

As of now, the fix is only applied to the test system. I'd be happy if someone else tests and confirms the bug is resolved.
Comment 3 Jonathan Garbee 2012-10-29 02:02:45 UTC 
Is this still an issue?  I haven't seen any issues with the commenting system.