This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 5537 - Checker aborts on bad URI in redirect
Summary: Checker aborts on bad URI in redirect
Status: RESOLVED FIXED
Alias: None
Product: mobileOK Basic checker
Classification: Unclassified
Component: Java Library (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: Sean Owen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-06 16:40 UTC by Dominique Hazael-Massieux
Modified: 2008-03-07 15:32 UTC (History)
0 users

See Also:


Attachments

Description Dominique Hazael-Massieux 2008-03-06 16:40:38 UTC
similar to #5536, when we try to resolve a URI for a redirect, the checker aborts with the following trace when the URI is invalid:
xception in thread "main" java.lang.IllegalArgumentException: Invalid uri 'http://himedia.112.2o7.net/b/ss/hmReportSuiteID/1/H.10--NS/0?[AQB]&pccr=true&g=none&[AQE]': Invalid query
        at org.apache.commons.httpclient.HttpMethodBase.<init>(HttpMethodBase.java:222)
        at org.apache.commons.httpclient.methods.GetMethod.<init>(GetMethod.java:89)
        at org.w3c.mwi.mobileok.basic.HTTPResource.<init>(HTTPResource.java:110)
        at org.w3c.mwi.mobileok.basic.HTTPResource.<init>(HTTPResource.java:82)
        at org.w3c.mwi.mobileok.basic.HTTPImageResource.<init>(HTTPImageResource.java:38)
        at org.w3c.mwi.mobileok.basic.Preprocessor.preprocess(Preprocessor.java:111)
        at org.w3c.mwi.mobileok.basic.Tester.getPreprocessorResults(Tester.java:79)
        at org.w3c.mwi.mobileok.basic.Tester.main(Tester.java:191)

This would again be better reported as HTTP_RESPONSE-1
Comment 1 Sean Owen 2008-03-07 03:17:27 UTC
Question on this one -- according to the code this is kinda intended
behavior. If the last request ended in some kind of exception we
assume we don't actually have a document to test, so there are no
results to report.

I kind of agree with this and recall a long argument on a whiteboard
about this. Just checking, what do people think about the right
behavior here? Garbage in, garbage out, I say, so I am not
particularly concerned if a situation like this results in an
exception (subsequently, looks like a change has turned this internal
exception into a more appropriate TestException), or if it becomes
some meaningless test results stating that the result is fail fail
fail because the body is empty and all kinds of screwed up as a
result. Just a different garbage out.

I'm happy to 'fix' this, just want to know if everyone agrees with
that, or whether this needs discussion.
Comment 2 Sean Owen 2008-03-07 15:32:01 UTC
This immediate issue was fixed a while ago as Abel says.

Per our discussion on the list, I removed the code that throws a different exception in this case, because there is no document content.