17:48:48 <RRSAgent> RRSAgent has joined #aria-apg
17:48:52 <RRSAgent> logging to https://www.w3.org/2023/06/27-aria-apg-irc
17:48:52 <Zakim> RRSAgent, make logs Public
17:48:53 <Zakim> please title this meeting ("meeting: ..."), Matt_King
17:49:11 <Matt_King> MEETING: ARIA Authoring Practices Task Force
17:49:21 <Matt_King> CHAIR: Matt King
17:49:25 <Matt_King> present+
17:49:33 <Matt_King> rrsagent, make minutes
17:49:34 <RRSAgent> I have made the request to generate https://www.w3.org/2023/06/27-aria-apg-minutes.html Matt_King
17:50:21 <Matt_King> TOPIC: Review agenda and meeting dates
17:50:35 <Matt_King> View agenda at https://github.com/w3c/aria-practices/wiki/June-27%2C-2023-Agenda
17:50:59 <Matt_King> No meeting on July 4 or July 18
17:51:09 <Matt_King> Next meeting on July 11
17:51:24 <Matt_King> rrsagent, make minutes
17:51:25 <RRSAgent> I have made the request to generate https://www.w3.org/2023/06/27-aria-apg-minutes.html Matt_King
18:03:05 <jugglinmike> jugglinmike has joined #aria-apg
18:06:13 <jugglinmike> present+ jugglinmike
18:06:15 <jugglinmike> scribe+ jugglinmike
18:06:20 <howard-e> howard-e has joined #aria-apg
18:06:25 <howard-e> present+
18:09:20 <jugglinmike> Topic: Status of Site Updates
18:09:30 <jugglinmike> Matt_King: On June 20, Shawn published 7 changes to production
18:09:38 <jugglinmike> Matt_King: https://github.com/w3c/wai-aria-practices/pull/227
18:10:08 <jugglinmike> Matt_King: Somehow, the link checker passed on the pull request but that it was not working in production
18:10:47 <jugglinmike> howard-e: I saw that. I was wondering if it was one of the links that is redirected by the WAI team. dmontalvo might be able to speak to that
18:11:00 <jugglinmike> dmontalvo: It wasn't a redirect as far as I know
18:11:16 <jugglinmike> Matt_King: I wonder if this was a server hiccup
18:11:28 <jugglinmike> dmontalvo: It could be; I don't have any other theories at the moment
18:12:02 <jugglinmike> Matt_King: We have a few things queued up for the next publication (they are three things listed in the agenda for today's meeting). We may publish them during the week of July 10
18:12:25 <Siri> Siri has joined #aria-apg
18:12:39 <jugglinmike> Topic: Pull request reviews
18:12:50 <jugglinmike> Subtopic: PR2729: Feed Example: Convert images to inline SVG by frozenzia
18:12:59 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2729
18:14:26 <arigilmore> arigilmore has joined #aria-apg
18:14:39 <jugglinmike> Matt_King: We need visual review. I've partially tested with a screen reader using two browsers, but we should probably have additional verification from an accessibility standpoint (mostly the contrast). We also need someone to look at the code
18:15:24 <shawn> shawn has joined #aria-apg
18:15:37 <jugglinmike> dmontalvo: I can double-check this with a screen reader in Safari
18:15:41 <jugglinmike> present+ Siri
18:16:09 <jugglinmike> Siri: if this can wait until the week of July 10, then I can review visually
18:16:29 <jugglinmike> present+ Andrea_Cardona
18:16:34 <jugglinmike> Andrea_Cardona: I can review the code
18:17:27 <jugglinmike> Matt_King: Great. You're all assigned. Thank you!
18:18:26 <jugglinmike> jamesn: Heads up: I think the high-contrast is not right
18:18:43 <jugglinmike> subtopic: PR 2723: Select-only Combobox Example: Fix scroll event listener bug by ariellalgilmore
18:18:55 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2723
18:19:18 <jugglinmike> arigilmore: The fixes I've tried are causing either a keyboard issue or a mouse issue, so we've converted it back to draft for now
18:19:40 <jugglinmike> arigilmore: We'll take another try, but we might reach out to the team to see if anyone has other suggestions
18:19:43 <jugglinmike> present+ arigilmore
18:19:59 <jugglinmike> subtopic: PR2736: Add AT Support tables for modal dialog, 1 slider, and navigation menu button by mcking65
18:20:04 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2736
18:20:23 <jugglinmike> Matt_King: There isn't much to review here. These three new support tables should look just like the others
18:20:34 <jugglinmike> Matt_King: The only difference is that I put these new ones higher on their pages
18:21:28 <jugglinmike> Matt_King: I think I'll just have Jemma look at this
18:21:38 <jugglinmike> subtopic: PR2737: Reposition AT support tables higher on the page by mcking65
18:21:43 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2737
18:22:01 <jugglinmike> Matt_King: I don't think this should cause any problems, but I'm wondering if anyone here has an objection to changing the order of sections on the page
18:22:28 <jugglinmike> [no comments]
18:22:38 <jugglinmike> Matt_King: I'll leave this as an editor's thing and see if Jemma has any feedback on it
18:22:51 <jugglinmike> subtopic: PR2388: Related Documents links - Insufficient contrast ratio by jnurthen
18:23:01 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2388
18:23:19 <jugglinmike> Matt_King: This is somewhat old. I wonder if anything has changed in a way that has made this unnecessary
18:23:38 <dmontalvo> present+ Daniel
18:23:59 <jugglinmike> Matt_King: Given that it's a one-line change, it might be easier to re-create the pull request rather than rebase the existing one
18:25:48 <jugglinmike> jamesn: The tab on the page looks to be the same color, and I don't see why one would fail and the other would not
18:25:57 <jugglinmike> Matt_King: Is this unique to the "Landmarks" page?
18:25:59 <jugglinmike> jamesn: Yes
18:26:16 <jugglinmike> Matt_King: I want to re-do these pages because they're hard to maintain in their current form
18:26:37 <jugglinmike> Matt_King: Since this is a minor issue, we may want to just let it be until we are able to take on the larger issue
18:26:59 <jugglinmike> jamesn: On the other hand, this is super simple, so we could fix it without much effort
18:27:27 <jugglinmike> Matt_King: That's true; it could be several months before we can improve the pages. If someone wants to land a quick fix now, that would also be good
18:27:38 <jugglinmike> jamesn: Okay, I'll do that, now
18:28:01 <jugglinmike> subtopic: PR2733: Combobox Pattern: Simplify wording of description in "About This Pattern" section by mcking65
18:28:08 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2733
18:28:24 <jugglinmike> Matt_King: This is an editorial change; I tried to simplify some wording based on feedback we received
18:29:37 <jugglinmike> Matt_King: The changes are all in the first two paragraphs for the Combobox pattern
18:29:59 <Matt_King> p1: A combobox is an input widget that has an associated popup. The popup enables users to choose a value for the input from a collection. The popup may be a
18:30:01 <Matt_King> listbox, grid, tree, or dialog.
18:30:32 <jugglinmike> s/p1:/paragraph 1 reads:/
18:31:19 <jugglinmike> Matt_King: If no one sees any typos, then I'd appreciate an approval on the pull request so that we can move forward
18:31:47 <jugglinmike> Matt_King: The other change was spreading the text into two paragraphs
18:35:35 <jugglinmike> subtopic: PR2725: Fix aria-level in treegrid example 1 by tryggvigy
18:35:44 <jugglinmike> github: https://github.com/w3c/aria-practices/pull/2725
18:36:07 <jugglinmike> Matt_King: I believe the person who submitted this is fixing an issue that doesn't exist, and I responded as much in a comment
18:36:29 <jugglinmike> Matt_King: I wonder if there is something about the visual design of the tree grid that led the author to suspect that there are three levels
18:38:42 <jugglinmike> howard-e: the indentation does seem visually ambiguous to me
18:47:00 <jugglinmike> jugglinmike: The first level of children are almost vertically aligned with their parent. The offset for that specific level is minimal
18:47:04 <jugglinmike> Andrea_Cardona: Agreed
18:54:46 <jugglinmike> arigilmore: I think this needs more indention for the second level (that is, the first level of children)
18:55:29 <jugglinmike> jugglinmike: It might also be good to add a second "thread", since the example currently only has a single top-level item, making it difficult to recognize
18:55:59 <jugglinmike> Topic: Running tests on macOS
18:57:21 <jugglinmike> Andrea_Cardona: Running this on my end, I can see a number of files checked and a timeout reported by Ava. It tells me that 57 hooks failed
18:57:31 <jugglinmike> Matt_King: There are exactly 57 examples, so that's all of them
18:58:15 <jugglinmike> Andrea_Cardona: I believe the errors I'm observing are different than what the reporter has shared
18:58:26 <jugglinmike> github: https://github.com/w3c/aria-practices/issues/2735
18:59:14 <jugglinmike> Matt_King: Paul was following the instructions for new contributors and ran into this problem right here. It's quite distracting, and I'm very concerned that we have instructions for new contributors that are leading them astray
19:00:17 <jugglinmike> Matt_King: We designed the regression tests to be able to run them locally, and I think they SHOULD be run locally, but if this is going to take a long time to address, I wonder if we should change the recommendation to rely on the CI system to run the regression tests
19:01:27 <jugglinmike> Andrea_Cardona: Yeah, arigilmore and I have relied on the CI system in that way in the past
19:03:04 <jugglinmike> Andrea_Cardona: It's somewhat slow, though!
19:04:55 <jugglinmike> jugglinmike: It can also be intimidating for new contributors to make their first pull request. It would be intimidating to have to wait for this automated feedback until *after* you've shared your work publicly
19:07:07 <jugglinmike> howard-e: They run reliably for me when I use Node.js 16 instead of Node.js 18. I'd be reluctant to pin to an old release of Node.js, though
19:07:47 <jugglinmike> Zakim, end the meeting
19:07:47 <Zakim> As of this point the attendees have been Matt_King, jugglinmike, howard-e, Siri, Andrea_Cardona, arigilmore, Daniel
19:07:49 <Zakim> RRSAgent, please draft minutes
19:07:50 <RRSAgent> I have made the request to generate https://www.w3.org/2023/06/27-aria-apg-minutes.html Zakim
19:07:57 <Zakim> I am happy to have been of service, jugglinmike; please remember to excuse RRSAgent.  Goodbye
19:07:57 <Zakim> Zakim has left #aria-apg